Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle missing explicite custom types #323

Merged
merged 1 commit into from
Mar 11, 2024
Merged

feat: Handle missing explicite custom types #323

merged 1 commit into from
Mar 11, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird changed the base branch from main to feat/bound_querier_improve March 11, 2024 08:45
@kulikthebird kulikthebird linked an issue Mar 11, 2024 that may be closed by this pull request
Warn on missing #[custom(msg=...)] or ExecC on trait #162
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.27%. Comparing base (5970be8) to head (a8522af).

Files Patch % Lines
sylvia-derive/src/input.rs 50.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   85.45%   85.27%   -0.19%     
==========================================
  Files          37       37              
  Lines        2695     2709      +14     
==========================================
+ Hits         2303     2310       +7     
- Misses        392      399       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird added this to the 1.0.0 milestone Mar 11, 2024
@kulikthebird
Copy link
Contributor Author

There's a problem with coverage, since we do not have a proper errors/warnings testing setup at the moment. To be fixed by #98

jawoznia
jawoznia approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulikthebird kulikthebird self-assigned this Mar 11, 2024
@kulikthebird kulikthebird force-pushed the feat/bound_querier_improve branch from a9f7128 to 6a4136d Compare March 11, 2024 16:57
Base automatically changed from feat/bound_querier_improve to main March 11, 2024 17:11
@kulikthebird kulikthebird force-pushed the feat/handle_missing_exec_and_custom branch from 1a8dfd7 to a8522af Compare March 11, 2024 17:12
@kulikthebird kulikthebird enabled auto-merge (squash) March 11, 2024 17:16
@kulikthebird kulikthebird merged commit 606a812 into main Mar 11, 2024
9 of 11 checks passed
@kulikthebird kulikthebird deleted the feat/handle_missing_exec_and_custom branch March 11, 2024 17:30
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Merged
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawoznia jawoznia jawoznia approved these changes

@hashedone hashedone Awaiting requested review from hashedone

Assignees

@kulikthebird kulikthebird

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Warn on missing #[custom(msg=...)] or ExecC on trait
2 participants
@kulikthebird @jawoznia